Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FSADT1-751): code cleanup and external libs #1287

Closed
wants to merge 20 commits into from
Closed

feat(FSADT1-751): code cleanup and external libs #1287

wants to merge 20 commits into from

Conversation

paulushcgcj
Copy link
Contributor

@paulushcgcj paulushcgcj commented Oct 30, 2024 •
edited by github-actions bot
Loading

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Updated existing tests

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

Thanks for the PR!

Deployments, as required, will be available below:
Any successful deployments (not always required) will be available here

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@github-actions GitHub Actions
Copy link
Contributor

Current changelog

Features

  • converting processor to native (76d17ba)

@mamartinezmejia mamartinezmejia changed the title feat(FSADT1-751)!: code cleanup and external libs feat(FSADT1-751): code cleanup and external libs Oct 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

Current changelog

Features

  • converting processor to native (76d17ba)

@github-actions GitHub Actions
Copy link
Contributor

Current changelog

Features

@github-actions GitHub Actions
Copy link
Contributor

Current changelog

Features

@github-actions GitHub Actions
Copy link
Contributor

Current changelog

Features

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Current changelog

Features

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Current changelog

Features

@paulushcgcj paulushcgcj marked this pull request as ready for review November 5, 2024 13:45
@paulushcgcj
Copy link
Contributor Author

Closing this task. Due to the way our organization and repositories are set, the Maven packages published are owned by the BCGov GitHub organization. Due to that and some other maven package issues on GitHub, it is not possible to allow other repos to consume the packages without the use of PAT (personal access tokens).

Maybe in the future, we get back to this initiative and once again refactor the code to allow this, but for now, we are closing this as a failed attempt.

@paulushcgcj paulushcgcj closed this Nov 5, 2024
@paulushcgcj paulushcgcj deleted the feat/FSADT1-751 branch November 5, 2024 14:23
@paulushcgcj paulushcgcj mentioned this pull request Nov 5, 2024
Closed
@paulushcgcj paulushcgcj linked an issue Nov 5, 2024 that may be closed by this pull request
chore(ci): common file(s) across builds #1288
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DerekRoberts DerekRoberts Awaiting requested review from DerekRoberts DerekRoberts is a code owner

@mamartinezmejia mamartinezmejia Awaiting requested review from mamartinezmejia mamartinezmejia is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore(ci): common file(s) across builds
1 participant
@paulushcgcj